skip verification of class ID in JS_GetOpaque if class_id is 0 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using QuickJS from C++ I'd like to be able to get the opaque pointer back without necessarily knowing the class ID of the value.
As an example, I have a Parent class in C++ and multiple classes that extend it: Child1, Child2..., each with their own wrapping JS class. I want to create a JS function which can take any of these child classes, cast the opaque value to a
Parent *and call methods on that.Since 0 is not a valid class ID, using it to disable verification works well.